Uploaded image for project: 'Pentaho Data Integration - Kettle'
  1. Pentaho Data Integration - Kettle
  2. PDI-16921

Concurrent access to outputRowSets in Mapping Init

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Severity: Urgent
    • Resolution: Fixed
    • Affects Version/s: 6.1.0.13 GA
    • Fix Version/s: 8.1.0 GA
    • Component/s: Step
    • Labels:
    • Story Points:
      0
    • PDI Sub-component:
    • Notice:
      When an issue is open, the "Fix Version/s" field conveys a target, not necessarily a commitment. When an issue is closed, the "Fix Version/s" field conveys the version that the issue was fixed in.
    • Sprint Team:
      Tatooine (Maint)

      Description

      Mappings create their InputRowSets and OutputRowSets themselves and attach them to the corresponding Steps in the init phase.
      If two or more Mappings are connected to the same Input- or Output-Step this can lead to concurrent writes to the InputStep's OutputRowSets or OutputStep's InputRowSets, which may corrupt these Lists.

      This can cause dangling InputRowSets in Mappings, which will never receive Rows and stall forever, or NPEs like the following:

      java.lang.NullPointerException                                                      
       at org.pentaho.di.trans.step.BaseStep.setOutputDone(BaseStep.java:2427)            
       at org.pentaho.di.trans.steps.filterrows.FilterRows.processRow(FilterRows.java:79) 
       at org.pentaho.di.trans.step.RunThread.run(RunThread.java:62)                      
       at java.lang.Thread.run(Thread.java:748)                                           
      

      To prevent this, the writes to the other Steps RowSets in MappingInput.setConnectorSteps and MappingOutput.setConnectorSteps needs to be synchronized.

        Attachments

          Activity

            People

            Assignee:
            upihin Uladzimir Pihin (Inactive)
            Reporter:
            topsy Tobias Krippendorf
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: