Uploaded image for project: 'Pentaho Data Integration - Kettle'
  1. Pentaho Data Integration - Kettle
  2. PDI-15478

Salesforce Step doesn't prevent transformation from running if there is a connection error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Severity: Low
    • Resolution: Fixed
    • Affects Version/s: 6.1.0.1 GA
    • Fix Version/s: 7.0.0 GA
    • Component/s: Step
    • Labels:
    • Story Points:
      0
    • Notice:
      When an issue is open, the "Fix Version/s" field conveys a target, not necessarily a commitment. When an issue is closed, the "Fix Version/s" field conveys the version that the issue was fixed in.
    • Steps to Reproduce:
      Hide
      1. Create a transformation which uses a Salesforce step
      2. Provide invalid Salesforce credentials
      3. Execute the transformation

      Expected Result: The transformation fails, and there are no log messages or Java stack traces that include the term processRow
      Actual Result: The transformation fails, but the term processRow does appear in the log messages.

      Show
      Create a transformation which uses a Salesforce step Provide invalid Salesforce credentials Execute the transformation Expected Result: The transformation fails, and there are no log messages or Java stack traces that include the term processRow Actual Result: The transformation fails, but the term processRow does appear in the log messages.

      Description

      In the Salesforce Upsert, Salesforce Update, and Salesforce Delete steps (and technically the Input step), if a connection fails to connect for some reason, the step still reports a successful init, allowing the transformation to begin processing rows of data.

      As the connection is being created during the init process, and that we capture the exception (and log it), we should return the proper return value to prevent the transformation from being executed, as it will fail anyways when the step receives its first row.

      2016/07/05 13:16:09 - Spoon - Transformation opened.
      2016/07/05 13:16:09 - Spoon - Launching transformation [PDI-15478]...
      2016/07/05 13:16:09 - Spoon - Started the transformation execution.
      2016/07/05 13:16:09 - PDI-15478 - Dispatching started for transformation [PDI-15478]
      2016/07/05 13:16:11 - Salesforce Insert.0 - ERROR (version 6.1.0.3-223, build 1 from 2016-06-16 15.11.37 by buildguy) : Error occurred during initialization
      2016/07/05 13:16:11 - Salesforce Insert.0 - Please be sure that you have a valid username and password.
      2016/07/05 13:16:11 - Generate Rows.0 - Finished processing (I=0, O=0, R=0, W=10, U=0, E=0)
      2016/07/05 13:16:11 - Salesforce Insert.0 - ERROR (version 6.1.0.3-223, build 1 from 2016-06-16 15.11.37 by buildguy) : Unexpected error
      2016/07/05 13:16:11 - Salesforce Insert.0 - ERROR (version 6.1.0.3-223, build 1 from 2016-06-16 15.11.37 by buildguy) : org.pentaho.di.core.exception.KettleStepException: 
      2016/07/05 13:16:11 - Salesforce Insert.0 - Error while inserting data in Salesforce : org.pentaho.di.core.exception.KettleException: 
      2016/07/05 13:16:11 - Salesforce Insert.0 - Failed in writeToSalesForce: 
      2016/07/05 13:16:11 - Salesforce Insert.0 - Failed to insert object, error message was: 
      2016/07/05 13:16:11 - Salesforce Insert.0 - Error while doing insert operation, error message was: UNKNOWN_EXCEPTION: Destination URL not reset. The URL returned from login must be set in the SforceService
      2016/07/05 13:16:11 - Salesforce Insert.0 - 
      2016/07/05 13:16:11 - Salesforce Insert.0 - 
      2016/07/05 13:16:11 - Salesforce Insert.0 - 
      2016/07/05 13:16:11 - Salesforce Insert.0 - 
      2016/07/05 13:16:11 - Salesforce Insert.0 - 	at org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsert.processRow(SalesforceInsert.java:115)
      2016/07/05 13:16:11 - Salesforce Insert.0 - 	at org.pentaho.di.trans.step.RunThread.run(RunThread.java:62)
      2016/07/05 13:16:11 - Salesforce Insert.0 - 	at java.lang.Thread.run(Thread.java:745)
      2016/07/05 13:16:11 - Salesforce Insert.0 - Finished processing (I=0, O=0, R=10, W=0, U=0, E=1)
      2016/07/05 13:16:11 - PDI-15478 - ERROR (version 6.1.0.3-223, build 1 from 2016-06-16 15.11.37 by buildguy) : Errors detected!
      2016/07/05 13:16:11 - Spoon - The transformation has finished!!
      2016/07/05 13:16:11 - PDI-15478 - ERROR (version 6.1.0.3-223, build 1 from 2016-06-16 15.11.37 by buildguy) : Errors detected!
      2016/07/05 13:16:11 - PDI-15478 - ERROR (version 6.1.0.3-223, build 1 from 2016-06-16 15.11.37 by buildguy) : Errors detected!
      2016/07/05 13:16:11 - PDI-15478 - Transformation detected one or more steps with errors.
      2016/07/05 13:16:11 - PDI-15478 - Transformation is killing the other steps!
      

        Attachments

          Activity

            People

            Assignee:
            bmarini Brian Marini
            Reporter:
            mtucker Matt Tucker
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: