Uploaded image for project: 'Pentaho Data Integration - Kettle'
  1. Pentaho Data Integration - Kettle
  2. PDI-15057

Many step and job entries don't clone properly which will lead to failures in Carte

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Severity: Urgent
    • Resolution: Fixed
    • Affects Version/s: 5.4.0 GA, 6.0.1 GA, 6.1.0 GA
    • Fix Version/s: 7.0.0 GA
    • Component/s: Job, Step
    • Labels:
      None
    • Story Points:
      0
    • Notice:
      When an issue is open, the "Fix Version/s" field conveys a target, not necessarily a commitment. When an issue is closed, the "Fix Version/s" field conveys the version that the issue was fixed in.
    • Steps to Reproduce:
      Hide

      See PDI-14929 as an example step (MySQLBulkLoader) that has this issue. Other steps found include MonetDBBulkLoad ( missing fieldFormatOk copy in clone ), MultiMergeJoinMeta ( not cloning the keyFields array ), MergeRowsMeta ( not cloning keyFields or valueFields array ), and the list goes on.

      Show
      See PDI-14929 as an example step (MySQLBulkLoader) that has this issue. Other steps found include MonetDBBulkLoad ( missing fieldFormatOk copy in clone ), MultiMergeJoinMeta ( not cloning the keyFields array ), MergeRowsMeta ( not cloning keyFields or valueFields array ), and the list goes on.

      Description

      Many of the clone() functions aren't performing a deep clone, aren't cloning all the arrays necessary to function in Carte, or are using for/next loops for copying arrays.

      This case covers making sure all clone() methods with array fields get properly deeply cloned, and also use the much faster ( twice as fast ) System.arraycopy instead of a for/next loop to copy arrays.

        Attachments

        1. log.txt
          8 kB
        2. pdi-15057.ktr
          32 kB
        3. sales_data_1.csv
          2 kB
        4. sales_data_2.csv
          3 kB
        5. test_table.sql
          0.6 kB

          Issue Links

            Activity

              People

              Assignee:
              mbatchelor Marc Batchelor (Inactive)
              Reporter:
              mbatchelor Marc Batchelor (Inactive)
              Votes:
              3 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: