Uploaded image for project: 'Pentaho Data Integration - Kettle'
  1. Pentaho Data Integration - Kettle
  2. PDI-11597

Denormalizer step: 100 + null = null

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Severity: High
    • Resolution: Fixed
    • Affects Version/s: 5.0.0 GA (5.0.0 GA Suite Release)
    • Fix Version/s: 5.1.0 GA
    • Component/s: Step
    • Labels:
    • Story Points:
      1
    • PDI Sub-component:
    • Notice:
      When an issue is open, the "Fix Version/s" field conveys a target, not necessarily a commitment. When an issue is closed, the "Fix Version/s" field conveys the version that the issue was fixed in.
    • Sprint Team:
      Pervach

      Description

      Using sum function for denormalizer step with null and not-null input values hadles cases for
      100 + null = null
      Compare to GroupBy step which handle such cases as
      100 + null = 100

      This is caused by Denormalizer step uses ValueDataUtil.plus( ... ) calls,
      while GroupBy uses ValueDataUtil.sum( ... ) calls.

      see
      https://github.com/pentaho/pentaho-kettle/blob/3542bec0507e899bc16fee9a7bf40ed43b09f0fc/core/src/org/pentaho/di/core/row/ValueDataUtil.java#L401

      and
      https://github.com/pentaho/pentaho-kettle/blob/3542bec0507e899bc16fee9a7bf40ed43b09f0fc/core/src/org/pentaho/di/core/row/ValueDataUtil.java#L451

      implementation details.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              alena_khamitsevich Alena Khamitsevich (Inactive)
              Reporter:
              dzmitry_by Dzmitry Prakapenka (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: