Uploaded image for project: 'Pentaho Data Integration - Kettle'
  1. Pentaho Data Integration - Kettle
  2. PDI-8661

Various Job Entry exceptions aren't getting the underlying exception logged

    Details

      Description

      After briefly working on PDI-8656, I decided to grep for exceptions in the job entries and see if there were any more not logged exceptions. There were, and this case is to track them:

      • copyfiltes
      • job
      • movfiles
        *pgpdecryptfiles
        *pgpencryptfiles
      • Additional lines in ssh2get and ssh2put
      • trans
      • zipfile

      For all these, I changed the logError message to include the exception so that the error log gets the full stack trace. In the case of the ssh2get, the error now looks like this:

      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : Can not delete remote file [/WRITE/1989656.log.250]
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : com.trilead.ssh2.SFTPException: Permission denied (SSH_FX_PERMISSION_DENIED: The user does not have sufficient permissions to perform the operation.)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at com.trilead.ssh2.SFTPv3Client.expectStatusOKMessage(SFTPv3Client.java:556)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at com.trilead.ssh2.SFTPv3Client.rm(SFTPv3Client.java:974)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.entries.ssh2get.JobEntrySSH2GET.deleteOrMoveFiles(JobEntrySSH2GET.java:1089)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.entries.ssh2get.JobEntrySSH2GET.copyFile(JobEntrySSH2GET.java:1276)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.entries.ssh2get.JobEntrySSH2GET.GetFiles(JobEntrySSH2GET.java:1153)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.entries.ssh2get.JobEntrySSH2GET.execute(JobEntrySSH2GET.java:905)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.Job.execute(Job.java:589)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.Job.execute(Job.java:728)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.Job.execute(Job.java:443)
      2012/10/02 16:41:16 - SSH2 Get - ERROR (version 4.4.0, build 1 from 2012-10-02 16.34.15 by mbatchelor) : at org.pentaho.di.job.Job.run(Job.java:363)

      So we get the full error and the full exception now.

      1. CopyFiles.kjb
        8 kB
        Jens Bleuel
      2. MoveFiles.kjb
        9 kB
        Jens Bleuel
      3. Zip.kjb
        8 kB
        Jens Bleuel

        Activity

        Hide
        mbatchelor Marc Batchelor added a comment -

        Checked into 4.4.0 (17445) and trunk (17446)

        Show
        mbatchelor Marc Batchelor added a comment - Checked into 4.4.0 (17445) and trunk (17446)
        Hide
        mbatchelor Marc Batchelor added a comment -

        Can you do the validation on this one?

        Thanks!!!

        Show
        mbatchelor Marc Batchelor added a comment - Can you do the validation on this one? Thanks!!!
        Hide
        jbleuel Jens Bleuel added a comment -

        Validated partly against pdi-ee-4.4.0-NIGHTLY-140 and code reviewed on http://source.pentaho.org/viewvc/svnkettleroot?view=rev&revision=17445

        • copyfiles: code reviewed, additional CopyFiles.kjb (create folder fails): exception does not show up in 4.3 and shows up now.
        • job: code reviewed (remote execution and monitoring)
        • movefiles: code reviewed, additional MoveFiles.kjb (create folder fails): exception does not show up in 4.3 and shows up now.
        • pgpdecryptfiles: code reviewed (create folder fails, call to method getMoveDestinationFilename() fails)
        • pgpencryptfiles: code reviewed (create folder fails, call to method getMoveDestinationFilename() fails)
        • Additional lines in ssh2get and ssh2put: code reviewed (call to methods rm(), createFolder(), mkdir() fails)
        • trans: code reviewed (remote execution and monitoring)
        • zipfile: code reviewed, additional Zip.kjb (create folder fails): exception does not show up in 4.3 and shows up now.
        Show
        jbleuel Jens Bleuel added a comment - Validated partly against pdi-ee-4.4.0-NIGHTLY-140 and code reviewed on http://source.pentaho.org/viewvc/svnkettleroot?view=rev&revision=17445 copyfiles: code reviewed, additional CopyFiles.kjb (create folder fails): exception does not show up in 4.3 and shows up now. job: code reviewed (remote execution and monitoring) movefiles: code reviewed, additional MoveFiles.kjb (create folder fails): exception does not show up in 4.3 and shows up now. pgpdecryptfiles: code reviewed (create folder fails, call to method getMoveDestinationFilename() fails) pgpencryptfiles: code reviewed (create folder fails, call to method getMoveDestinationFilename() fails) Additional lines in ssh2get and ssh2put: code reviewed (call to methods rm(), createFolder(), mkdir() fails) trans: code reviewed (remote execution and monitoring) zipfile: code reviewed, additional Zip.kjb (create folder fails): exception does not show up in 4.3 and shows up now.

          People

          • Assignee:
            jbleuel Jens Bleuel
            Reporter:
            mbatchelor Marc Batchelor
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: