Pentaho Data Integration - Kettle
  1. Pentaho Data Integration - Kettle
  2. PDI-724

Transformation wide rollback should occur on all steps in error

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Severe Severe
    • Resolution: Fixed
    • Affects Version/s: 2.5.0, 2.5.1, 2.5.2, 3.0.0 GA, 3.0.1
    • Fix Version/s: 3.0.2, 3.1.0 GA
    • Component/s: Database
    • Labels:
      None
    • Customer Case:
    • Notice:
      When an issue is open, the "Fix Version/s" field conveys a target, not necessarily a commitment. When an issue is closed, the "Fix Version/s" field conveys the version that the issue was fixed in.

      Description

      When an error arises on transformations with unique connections a rollback on this unique connection should be performed.
      This only works when the step in error is related to the unique connection. When other steps fail due to an error the rollback is not performed (e.g. the Text File Input or Abort step)

      Proposed solutions:
      1) Implement stopRunning() an all table output / database related steps and handle a rollback()
      2) On all table output / database related steps we could check the status for STATUS_STOPPED and treat this similar to an error.

      Any votes (my favorite would be 2)?

        Issue Links

          Activity

          Hide
          Matt Casters added a comment -
          Tested on "Oracle XE 10g" (Ubuntu 7.10) and "SQL Server 2005 Express" (Windoxs XP Pro in VMWare)
          Show
          Matt Casters added a comment - Tested on "Oracle XE 10g" (Ubuntu 7.10) and "SQL Server 2005 Express" (Windoxs XP Pro in VMWare)
          Hide
          Jens Bleuel added a comment -
          Works perfect with my test szenarios - great work Matt!
          --> ready to backport to 3.0.2
          Jens
          Show
          Jens Bleuel added a comment - Works perfect with my test szenarios - great work Matt! --> ready to backport to 3.0.2 Jens
          Hide
          Matt Casters added a comment -
          revision 6602 applied the backport to 3.0.2.
          My tests run, make sure to re-run all yours too.

          Matt
          Show
          Matt Casters added a comment - revision 6602 applied the backport to 3.0.2. My tests run, make sure to re-run all yours too. Matt
          Hide
          Matt Casters added a comment -
          Make that revision 6604, I forgot to commit the changes to the "en_US" i18n messages file.
          Show
          Matt Casters added a comment - Make that revision 6604, I forgot to commit the changes to the "en_US" i18n messages file.
          Hide
          Jens Bleuel added a comment -
          Works, ready to be shipped.
          Also changed case title, it's an improvement, and added "fixed for 3.0.2".
          Show
          Jens Bleuel added a comment - Works, ready to be shipped. Also changed case title, it's an improvement, and added "fixed for 3.0.2".

            People

            • Assignee:
              Jens Bleuel
              Reporter:
              Jens Bleuel
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: