Pentaho Data Integration - Kettle

create new repository with spoon

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.1.0 GA
  • Fix Version/s: 3.2.0 GA
  • Component/s: User Interface
  • Operating System/s:
    Windows XP, Fedora Core 3.x, Fedora Core 4.x, RedHat Enterprise Linux 4, SuSE Enterprise 10, Mac OSX, RedHat Enterprise Linux 3
  • Description:
    Hide
    on a new pdi 3.1.0-M2 installation:
    - startup spoon
    - click on: Repository 'New' (because it's empty)
    - click on: Select database connection 'New' (because it's empty)
    --> i can't type anything into the 'Database connection' dialog because the 'Repository information' dialog is the active window (i can't change to database)

    if i close the 'Repository information' dialog, i can use the 'Database connection' dialog, but after hitting 'ok' (or 'cancel') i get:
    Fatal error: org.eclipse.swt.SWTException: Widget is disposed
    spoon shuts down

    so, i can't create a new repository :(
    Show
    on a new pdi 3.1.0-M2 installation: - startup spoon - click on: Repository 'New' (because it's empty) - click on: Select database connection 'New' (because it's empty) --> i can't type anything into the 'Database connection' dialog because the 'Repository information' dialog is the active window (i can't change to database) if i close the 'Repository information' dialog, i can use the 'Database connection' dialog, but after hitting 'ok' (or 'cancel') i get: Fatal error: org.eclipse.swt.SWTException: Widget is disposed spoon shuts down so, i can't create a new repository :(

Issue Links

Duplicate
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roland added a comment - 20/May/08 4:12 PM
not broken in 3.0.3
Show
Roland added a comment - 20/May/08 4:12 PM not broken in 3.0.3
Hide
Permalink
Matt Casters added a comment - 21/May/08 3:19 AM
Gretchen, I'm sure this happens because the (XUL) database dialog is not a dialog at all rather a regular shell that tries to re-parent (setParent()) later on.

Since the RepositoryDialog is created SWT.APPLICATION_MODAL, focus is kept on the RepositoryDialog and the "DatabaseDialog" is just another information window opened in the background. (since there is no relationship between the 2)
Reparenting comes too late and doesn't seem to have an effect here.

Long term: we should see how we can avoid reparenting.
Short term: I'm going to avoid making the RepositoryDialog application modal.
Show
Matt Casters added a comment - 21/May/08 3:19 AM Gretchen, I'm sure this happens because the (XUL) database dialog is not a dialog at all rather a regular shell that tries to re-parent (setParent()) later on. Since the RepositoryDialog is created SWT.APPLICATION_MODAL, focus is kept on the RepositoryDialog and the "DatabaseDialog" is just another information window opened in the background. (since there is no relationship between the 2) Reparenting comes too late and doesn't seem to have an effect here. Long term: we should see how we can avoid reparenting. Short term: I'm going to avoid making the RepositoryDialog application modal.
Matt Casters made changes - 21/May/08 3:19 AM
Field Original Value New Value
Assignee Triage [ project admin ] Gretchen Moran [ gmoran ]
Hide
Permalink
Matt Casters added a comment - 21/May/08 3:28 AM
I applied a fix that removes the blocking issue in revision 7889. (RepositoriesDialog no longer starts RepositoryDialog application modal)
However, we probably can expect this thing to happen here and there again in the future.
Perhaps there is a way to create an SWT Dialog instead of an SWT Shell through XUL.

Downgrading this issue to an API cleanup effort since the core problem is fixed and no longer blocking.
Show
Matt Casters added a comment - 21/May/08 3:28 AM I applied a fix that removes the blocking issue in revision 7889. (RepositoriesDialog no longer starts RepositoryDialog application modal) However, we probably can expect this thing to happen here and there again in the future. Perhaps there is a way to create an SWT Dialog instead of an SWT Shell through XUL. Downgrading this issue to an API cleanup effort since the core problem is fixed and no longer blocking.
Matt Casters made changes - 21/May/08 3:28 AM
Component/s User Interface [ 10323 ]
Operating System/s [Windows XP] [Windows XP, Fedora Core 3.x, Fedora Core 4.x, RedHat Enterprise Linux 3, RedHat Enterprise Linux 4, SuSE Enterprise 10, Mac OSX]
Priority Blocker [ 1 ] Minor [ 4 ]
Hide
Permalink
Gretchen Moran added a comment - 21/May/08 7:04 AM
I'm working on the SWT Dialog for the XUL framework now. This won't get in to 3.1, but shortly after. Thanks for handling the fix for the critical issue guys.
Show
Gretchen Moran added a comment - 21/May/08 7:04 AM I'm working on the SWT Dialog for the XUL framework now. This won't get in to 3.1, but shortly after. Thanks for handling the fix for the critical issue guys.
Gretchen Moran made changes - 21/May/08 8:17 AM
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Gretchen Moran added a comment - 21/May/08 10:58 AM
I also added a qwuick fix to the database dialog - if you close the RepositoryDialog before you close the connection dialog, you will still get a widget is disposed error, causing Spoon to crash. I added a disposeListener to the dialog to kill the connection dialog with its parent.
Show
Gretchen Moran added a comment - 21/May/08 10:58 AM I also added a qwuick fix to the database dialog - if you close the RepositoryDialog before you close the connection dialog, you will still get a widget is disposed error, causing Spoon to crash. I added a disposeListener to the dialog to kill the connection dialog with its parent.
Gretchen Moran made changes - 27/May/08 9:20 AM
Status In Progress [ 3 ] Coded [ 10000 ]
Gretchen Moran made changes - 27/May/08 9:20 AM
Status Coded [ 10000 ] Ready For Test [ 10004 ]
Gretchen Moran made changes - 26/Jun/08 12:10 PM
Link This issue is duplicated by PDI-1420 [ PDI-1420 ]
Gretchen Moran made changes - 11/Jul/08 5:50 AM
Workflow dev_workflow_v3 [ 102872 ] Pentaho Engineering 3.0 Workflow [ 162457 ]
Jake Cornelius made changes - 26/Jun/09 2:05 PM
Status Ready For Test [ 10004 ] Resolved [ 5 ]
Fix Version/s 3.2.0 GA [ 10641 ]
Resolution Fixed [ 1 ]
Gretchen Moran made changes - 04/Aug/09 6:36 PM
Workflow Pentaho Engineering 3.0 Workflow [ 162457 ] Pentaho Engineering 4.0 Workflow [ 371865 ]
Marc Batchelor made changes - 04/Aug/09 8:40 PM
Workflow Pentaho Engineering 4.0 Workflow [ 371865 ] Pentaho Engineering 5.0 Workflow [ 412580 ]
Marc Batchelor made changes - 17/Aug/09 10:24 AM
Workflow Pentaho Engineering 5.0 Workflow [ 412580 ] Pentaho Engineering 6.0 Workflow [ 435480 ]
Marc Batchelor made changes - 06/May/10 6:59 PM
Workflow Pentaho Engineering 6.0 Workflow [ 435480 ] Pentaho Engineering 7.0 Workflow [ 503836 ]
Marc Batchelor made changes - 04/Aug/10 10:21 PM
Workflow Pentaho Engineering 7.0 Workflow [ 503836 ] Pentaho Engineering 8.0 Workflow [ 526263 ]
Transition Status Change Time Execution Times Last Executer Last Execution Date
Open Open In Progress In Progress
20h 44m
1
Gretchen Moran
21/May/08 8:17 AM
In Progress In Progress Coded Coded
6d 1h 2m
1
Gretchen Moran
27/May/08 9:20 AM
Coded Coded Ready For Test Ready For Test
2s
1
Gretchen Moran
27/May/08 9:20 AM
Ready For Test Ready For Test Resolved Resolved
395d 4h 44m
1
Jake Cornelius
26/Jun/09 2:05 PM

People

Dates

  • Created:
    20/May/08 11:32 AM
    Updated:
    26/Jun/09 2:05 PM
    Resolved:
    26/Jun/09 2:05 PM
Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Pentaho.org. Try JIRA - bug tracking software for your team.