Pentaho Analysis - Mondrian
  1. Pentaho Analysis - Mondrian
  2. MONDRIAN-1107

Mondrian does not call SegmentCache.getSegmentHeaders()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: High High
    • Resolution: Fixed
    • Affects Version/s: 3.5.0 GA (4.8.0 GA Suite Release)
    • Fix Version/s: 7.0.0 GA
    • Component/s: Caching
    • Labels:
      None
    • Notice:
      When an issue is open, the "Fix Version/s" field conveys a target, not necessarily a commitment. When an issue is closed, the "Fix Version/s" field conveys the version that the issue was fixed in.

      Description

      Using an external SegmentCache via SegmentCacheInjector.addCache(SegmentCache), Mondrian doesn't recognize cache content that was inserted before a server restart.

      Looking at source in git master branch, SegmentCache.getSegmentHeaders() is only called within SegmentCacheWorker.getSegmentHeaders(), which doesn't seem to be called anywhere.

        Issue Links

          Activity

          Hide
          Julian Hyde added a comment -

          I can see that SegmentCache.getSegmentHeaders() is only called from SegmentCacheWorker.getSegmentHeaders(), but no code calls that. These should be some event where mondrian queries the content of the cache. Maybe that event is where mondrian joins a cache; also, perhaps it should re-sync with the cache if it has received a lot of errors and/or a particular amount of time has elapsed.

          Show
          Julian Hyde added a comment - I can see that SegmentCache.getSegmentHeaders() is only called from SegmentCacheWorker.getSegmentHeaders(), but no code calls that. These should be some event where mondrian queries the content of the cache. Maybe that event is where mondrian joins a cache; also, perhaps it should re-sync with the cache if it has received a lot of errors and/or a particular amount of time has elapsed.
          Hide
          Will Gorman (Inactive) added a comment -

          Please work with QA on creating a regression test to our SpiraTest environment for this issue.

          Show
          Will Gorman (Inactive) added a comment - Please work with QA on creating a regression test to our SpiraTest environment for this issue.
          Hide
          Pedro Alves added a comment -

          Any news here?

          Show
          Pedro Alves added a comment - Any news here?
          Hide
          Luc Boudreau added a comment -

          Pedro, could you send us the code you have used to fix this issue? I remember you mentioned that you found a way to fix this.

          Show
          Luc Boudreau added a comment - Pedro, could you send us the code you have used to fix this issue? I remember you mentioned that you found a way to fix this.
          Hide
          Pedro Vale added a comment -

          hey guys. There's a pending pull request with the fix for this. It's here:

          https://github.com/pentaho/mondrian/pull/13

          Although this includes a bunch of other stuff, the commit you're looking for is this one:

          https://github.com/webdetails/mondrian/commit/9ab54555427f5482c56003cfd3ddff267b8086cc

          Show
          Pedro Vale added a comment - hey guys. There's a pending pull request with the fix for this. It's here: https://github.com/pentaho/mondrian/pull/13 Although this includes a bunch of other stuff, the commit you're looking for is this one: https://github.com/webdetails/mondrian/commit/9ab54555427f5482c56003cfd3ddff267b8086cc

            People

            • Assignee:
              Unassigned
              Reporter:
              Tiago Gomes Ferreira
            • Votes:
              8 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: